Repository navigation
Conversation
Co-authored-by: Muse Code <muse-code@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool call cards now have a Copy button on each expanded section and truncate long text behind a Show more toggle. Previously the full text always rendered in place and there was no quick way to reuse it.
Part of #2
Closes #37
What changed:
WorkbenchControls.tsxgets a Copy button that writes the exact section text to the clipboard and shows Copied for a short confirmation. The copied text is the same text the card displays, including the No input, No output, and Waiting for output fallbacks.TOOL_TEXT_PREVIEW_LIMIT) renders only the first 2000 characters with a Show more button. Show more reveals the full text and switches to Show less, which truncates again. Header summary, Running, Done, and Failed states, and collapsed-by-default behaviour are unchanged.Verified:
bun install --frozen-lockfilepassedbun run lintpassed, 0 warnings and 0 errorsbun run typecheckpassed across renderer, main, and preload configsbun run test:unitpassed, 71 testsbun run test:integration- the new ToolCard tests pass and the suite shows 37 passed with 6 failures inSettingsView.test.tsx. Those 6 failures reproduce on cleanorigin/mainin this environment (localStorageis undefined under the local Node 26 runtime,Cannot read properties of undefined (reading 'getItem')), so they are pre-existing here and not caused by this change. CI runs the same suite green.mise run buildpassedbun run test:e2eblocked in this environment. Electron fails to launch withLibrary not loaded: @rpath/Electron Framework.framework, and all 43 e2e tests skip. Noted once here per the fall-through rule and not retried.Proof:
.tmp/proof/tool-card-truncated.pngand.tmp/proof/tool-card-expanded.png. The capture log recordedhas Show more: true,truncated (no END-MARKER): true,has Copy buttons: true, then after clicking Show more,expanded (has END-MARKER): true. The expanded screenshot shows the Input and Output headings, both Copy buttons, the full log text, and the Show less toggle. The PNGs are kept under.tmp/proof/locally and are not committed, matching the scratch-capture rule for this repo. The temporary proof page was removed before committing.ToolCard.test.tsx:copies the exact output text and shows Copiedandtruncates long output and expands on Show more. Both failed before the change (2 failed, 2 passed) and pass after (4 passed).Known gaps and follow-ups: